fix: sync status not updating correctly #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue where
hasSyncedwas being reset after becoming true. This issue was due to theupdatefunction in theSyncStatusclass using thecopymethod and expecting default values to be persisted. However when theupdatefunction is run andcopyis invoked it does not know about the default values in theupdatefunction so it overwrites the previous values with null.This fixes the issue by not relying on default values from the
updatefunction.Previously
Now
I have also included an example implementation of using
hasSyncedin the demo.Testing
Implemented the change in the demo and tested to confirm it shows "busy syncing..." when hasSynced is not true and shows the content otherwise